[Webkit-unassigned] [Bug 98874] [GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98874





--- Comment #15 from Xan Lopez <xan.lopez at gmail.com>  2012-10-16 05:49:43 PST ---
(From update of attachment 168732)
View in context: https://bugs.webkit.org/attachment.cgi?id=168732&action=review

This seems reasonable in general, I just have a few comments and questions. Still somebody else needs to have a look at it, and I'd like to test the full thing (ephy patches included) before pushing it.

> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:182
> +        return;

As commented on jabber, seems weird to check for this kind of thing in a callback. Carlos told me we do it because we cannot check beforehand when the process is done, but maybe add a FIXME for it.

> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:195
> +

Also as commented on jabber, seems we are never notified when a favicon changen but its URIs stays the same. Not sure where this could be added as a FIXME, but it would be good to document somewhere this kind of thing.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:326
> +        return;

This seems like pushing the 'early return' religion a bit too far, but no big deal.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:182
> +    // and then when the icon is loaded.

What happens when you ask for the favicon the first time then? You get nothing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.