[Webkit-unassigned] [Bug 98874] [GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98874





--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-16 06:04:12 PST ---
(From update of attachment 168732)
View in context: https://bugs.webkit.org/attachment.cgi?id=168732&action=review

Thanks for reviewing it.

>> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:182
>> +        return;
> 
> As commented on jabber, seems weird to check for this kind of thing in a callback. Carlos told me we do it because we cannot check beforehand when the process is done, but maybe add a FIXME for it.

We would need to add a callback to the C API client to get notified when the URL import is completed

>> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:195
>> +
> 
> Also as commented on jabber, seems we are never notified when a favicon changen but its URIs stays the same. Not sure where this could be added as a FIXME, but it would be good to document somewhere this kind of thing.

The API doc for favicon-changed signals says: "This signal is emitted when the favicon URI of @page_uri has been changed to @favicon_uri in the database." so it's documented somewhere :-)

I was assuming we were not notified when the icon data changes, because this callback is never called for this page http://www.p01.org/releases/DEFENDER_of_the_favicon/ that changes the favicon dynamically, but I haven't tried other test cases, so I can be wrong.

>> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:182
>> +    // and then when the icon is loaded.
> 
> What happens when you ask for the favicon the first time then? You get nothing?

The first time icon is NULL, so notify::favicon will be emitted when it becomes not NULL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.