[Webkit-unassigned] [Bug 97651] [EFL] Make PageClient accessible to both WebKit and WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97651





--- Comment #4 from Regina Chung <heejin.r.chung at samsung.com>  2012-10-15 00:09:29 PST ---
(In reply to comment #2)
> (From update of attachment 168381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168381&action=review
> > Source/WebCore/platform/efl/WebPageClientEfl.h:23
> > +#include <Evas.h>
> Can we just declare some types istead of include Evas.h in header file.
Sure, removed the include and moved the type declarations in PageClientEfl.h to WebPageClientEfl.h

> > Source/WebCore/platform/efl/WebPageClientEfl.h:30
> > +class WebPageClientEfl {
> What do you think about adding this in WebCore namespae?
WebPageClientEfl is typedefed as PlatformPageClient in Widget.h
I'm not sure if it is a good idea to add it into the WebCore namespace...

> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:52
> > +    WebPageClientEfl* pageClient = 0;
> Can we move this below 54 line.
pageClient is needed outside of the if statement in line 54. (see line 98)

> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:63
> > +                sharedContext = static_cast<Evas_GL_Context*>(context->platformGraphicsContext3D());
> Can I know the meaning of this?
> I could not find usage of this value.
Sorry, sharedContext was supposed to be passed as the 2nd argument for evas_gl_context_create() (line 93). Will fix this in new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.