[Webkit-unassigned] [Bug 97651] [EFL] Make PageClient accessible to both WebKit and WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97651





--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-10-14 23:59:45 PST ---
(From update of attachment 168381)
View in context: https://bugs.webkit.org/attachment.cgi?id=168381&action=review

>> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:63
>> +                sharedContext = static_cast<Evas_GL_Context*>(context->platformGraphicsContext3D());
> 
> Can I know the meaning of this?
> 
> I could not find usage of this value.

Better question (answer in changelog) why is this different code path needed for webkit1? Could it use the same one as webkit2 (fake evas) or is there any advantages to this new approach?

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:119
> +bool GraphicsContext3DPrivate::createSurface(WebPageClientEfl* pageClient, bool renderDirectlyToHostWindow)

Why not adding the actual Evas_Object* instead? There is like almost nothing shared in WebPageClientEfl

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.