[Webkit-unassigned] [Bug 98344] [EFL] Add the file system path set/get APIs.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 4 00:52:05 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=98344
--- Comment #2 from Christophe Dumez <christophe.dumez at intel.com> 2012-10-04 00:52:30 PST ---
(From update of attachment 167043)
View in context: https://bugs.webkit.org/attachment.cgi?id=167043&action=review
> Source/WebKit/efl/ewk/ewk_settings.cpp:153
> + WebCore::LocalFileSystem::initializeLocalFileSystem(WTF::String::fromUTF8(path));
WTF:: is probably not needed.
WebCore::LocalFileSystem::initializeLocalFileSystem() can only be called *ONCE* due to the ASSERT(!s_instance); in debug mode.
This makes this API useless since ewk_settings_file_system_path_set() is already called once from ewk_main. Therefore, it is no longer possible for the app to change it later.
> Source/WebKit/efl/ewk/ewk_settings.h:132
> +EAPI void ewk_settings_file_system_path_set(const char* path);
Star on wrong side.
> Source/WebKit/efl/ewk/ewk_settings.h:145
> +EAPI const char* ewk_settings_file_system_path_get(void);
Star on wrong side.
> Source/WebKit/efl/tests/test_ewk_settings.cpp:35
> +* @brief Checking whether function properly returns correct value.
Missing space at beginning?
> Source/WebKit/efl/tests/test_ewk_settings.cpp:36
> +*/
Ditto.
> Source/WebKit/efl/tests/test_ewk_settings.cpp:41
> + ewk_settings_file_system_path_set("/WebKitEfl/FileSystem");
I'm not sure it is a very good example to use "/WebKitEfl/FileSystem". This may lead to permission problems later.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list