[Webkit-unassigned] [Bug 103335] [CSS Grid Layout] Support all specified breadth size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103335





--- Comment #9 from Julien Chaffraix <jchaffraix at webkit.org>  2012-11-30 10:52:37 PST ---
(From update of attachment 176987)
View in context: https://bugs.webkit.org/attachment.cgi?id=176987&action=review

We talked about the patch on IRC with Xan and decided to push the calc case to a follow-up bug as it seems to be more involved to get right (especially on the getComputedStyle side).

Btw, don't forget that you need to test the layout side of your change as your grid areas are now properly sized. You can follow the other examples (e.g. fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html) on how to get the grid areas size.

> LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set.html:50
> +.gridWithFitContent {
> +    -webkit-grid-columns: -webkit-fit-content;
> +    -webkit-grid-rows: -webkit-fit-available;
> +}

Probably good to test both values (fit-content, fit-available) for both properties.

> Source/WebCore/rendering/RenderGrid.cpp:145
> +            track.m_usedBreadth = valueForLength(trackStyles[i].length(), direction == ForColumns ? logicalWidth() : computeContentLogicalHeight(MainOrPreferredSize, trackStyles[i].length()), view());

Better! However you are doing the wrong resolution for the rows: you are resolving percentage trackStyle against itself which is not what you want. You want to resolve it against the grid element's style's logical height. I am sure this is why the tests are failing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.