[Webkit-unassigned] [Bug 103335] [CSS Grid Layout] Support all specified breadth size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103335





--- Comment #10 from Xan Lopez <xan.lopez at gmail.com>  2012-11-30 11:03:25 PST ---
(In reply to comment #9)
> > Source/WebCore/rendering/RenderGrid.cpp:145
> > +            track.m_usedBreadth = valueForLength(trackStyles[i].length(), direction == ForColumns ? logicalWidth() : computeContentLogicalHeight(MainOrPreferredSize, trackStyles[i].length()), view());
> 
> Better! However you are doing the wrong resolution for the rows: you are resolving percentage trackStyle against itself which is not what you want. You want to resolve it against the grid element's style's logical height. I am sure this is why the tests are failing.

Yeah, that nailed it!

I'll upload a new patch without the calc() support, and open a new bug to continue working on calc() after this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.