[Webkit-unassigned] [Bug 103679] [EFL][WK2] MiniBrowser should have a legacy mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103679





--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-30 07:47:41 PST ---
(From update of attachment 176962)
View in context: https://bugs.webkit.org/attachment.cgi?id=176962&action=review

> Source/WebKit2/ChangeLog:10
> +
> +        Allow calling WKViewCreate without creating a context first. A default context
> +        will be used.
> +

You should explain what that actually means. How is that related to the legacy mode.

> Tools/MiniBrowser/efl/main.c:1063
> -    window->ewk_view = ewk_view_smart_add(evas, smart, ewk_context_default_get());
> +    window->ewk_view = legacy_behavior_enabled ? (Evas_Object*)WKViewCreate(evas, 0, 0) : ewk_view_smart_add(evas, smart, ewk_context_default_get());

Why not make this more clean

if (legacy_behavior_enabled) {
   // Use raw WK2 api to create a view using legacy mode.
   window->ewk_view = (Evas_Object*)WKViewCreate(evas, 0, 0);
} else
   window->ewk_view = ewk_view_smart_add(evas, smart, ewk_context_default_get());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.