[Webkit-unassigned] [Bug 103679] [EFL][WK2] MiniBrowser should have a legacy mode
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 30 07:46:48 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=103679
--- Comment #7 from Yael <yael at webkit.org> 2012-11-30 07:49:05 PST ---
(In reply to comment #6)
> (From update of attachment 176962 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176962&action=review
>
> > Source/WebKit2/ChangeLog:10
> > +
> > + Allow calling WKViewCreate without creating a context first. A default context
> > + will be used.
> > +
>
> You should explain what that actually means. How is that related to the legacy mode.
>
> > Tools/MiniBrowser/efl/main.c:1063
> > - window->ewk_view = ewk_view_smart_add(evas, smart, ewk_context_default_get());
> > + window->ewk_view = legacy_behavior_enabled ? (Evas_Object*)WKViewCreate(evas, 0, 0) : ewk_view_smart_add(evas, smart, ewk_context_default_get());
>
> Why not make this more clean
>
> if (legacy_behavior_enabled) {
> // Use raw WK2 api to create a view using legacy mode.
> window->ewk_view = (Evas_Object*)WKViewCreate(evas, 0, 0);
> } else
> window->ewk_view = ewk_view_smart_add(evas, smart, ewk_context_default_get());
Because people usually ask me to condense lines as much as possible :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list