[Webkit-unassigned] [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103513





--- Comment #19 from Antoine Quint <graouts at apple.com>  2012-11-29 04:55:38 PST ---
(In reply to comment #5)
> (From update of attachment 176477 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176477&action=review
> 
> > Source/WebCore/inspector/InspectorLayerTreeAgent.h:69
> > +    bool enabled() { return m_enabled; }
> 
> Should be const.

I'm actually removing this method altogether, it's not used and serves no purpose.

> > Source/WebCore/inspector/InspectorLayerTreeAgent.h:85
> > +    PassRefPtr<TypeBuilder::LayerTree::Layer> buildObjectForLayer(RenderLayer*, bool);
> 
> Should be const RenderLayer*

This proves problematic as there is a call to updateLayerListsIfNeeded() make to the RenderLayer in that method.

> > Source/WebCore/inspector/InspectorLayerTreeAgent.h:86
> > +    PassRefPtr<TypeBuilder::LayerTree::IntRect> buildObjectForIntRect(IntRect);
> 
> const IntRect&

Will change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.