[Webkit-unassigned] [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103513





--- Comment #20 from Antoine Quint <graouts at apple.com>  2012-11-29 05:07:02 PST ---
(In reply to comment #12)
> (From update of attachment 176477 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176477&action=review
> 
> > Source/WebCore/CMakeLists.txt:1582
> > +    inspector/InspectorLayerTreeAgent.cpp
> 
> please keep the entries sorted

I'll be updating this file and all the others you mentioned to preserve sorting.

> >> Source/WebCore/inspector/Inspector.json:3266
> >> +                    { "name": "isRoot", "type": "boolean", "description": "Indicates whether this layer is the root." },
> > 
> > You might want to make it optional and imply that it is not root when omitted.
> 
> Is it necessary at all? It appears that parentId could be used to check for root instead. Actually, it looks like with current implementation you don't need either isRoot or parent, as these may be easily deduced from the tree that you return.

You're correct, I'm removing both .isRoot and .parentId.

> > Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:137
> > +PassRefPtr<TypeBuilder::LayerTree::Layer> InspectorLayerTreeAgent::buildObjectForLayer(RenderLayer* renderLayer, bool deep)
> 
> is deep ever false?

No, I'm removing this parameter.

Thanks for the useful feedback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.