[Webkit-unassigned] [Bug 101978] Web Inspector: Fix docking behaviour on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101978





--- Comment #4 from Roger Fong <roger_fong at apple.com>  2012-11-12 14:54:28 PST ---
> >> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:297
> >> +    // Make sure that m_attached is true so that setAttachedWindowHeight succeeds.
> > 
> > s/succeeds/doesn't return early/?
> 
> Should this say restoreAttachedWindowHeight instead of setAttachedWindowHeight?

I meant setAttachedWindowHeight because restore calls setAttachedWindowHeight which has a check:

if (!m_attached)
 return;

which prevents the final height from being et properly. I guess both are correct but I figured it'd be a little clearer using the method that actually fails. Do you think I should make it restoreAttachedWindowHeight tho?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.