[Webkit-unassigned] [Bug 101978] Web Inspector: Fix docking behaviour on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101978


Brian Weinstein <bweinstein at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173710|review?                     |review-
               Flag|                            |




--- Comment #3 from Brian Weinstein <bweinstein at apple.com>  2012-11-12 14:44:36 PST ---
(From update of attachment 173710)
View in context: https://bugs.webkit.org/attachment.cgi?id=173710&action=review

I'd like to see one more version with Tim's comments and mine addressed. Patch looks good though.

> Source/WebKit/win/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=100000

100000!!!

> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:258
> +        restoreAttachedWindowHeight();

A comment explaining why we are restoring the attached window height before attaching would be nice.

>> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:297
>> +    // Make sure that m_attached is true so that setAttachedWindowHeight succeeds.
> 
> s/succeeds/doesn't return early/?

Should this say restoreAttachedWindowHeight instead of setAttachedWindowHeight?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.