[Webkit-unassigned] [Bug 100995] [Qt][Mac][Win] r133182 broke the build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 00:35:49 PDT 2012


--- Comment #6 from Nandor Huszka <hnandor at inf.u-szeged.hu>  2012-11-02 00:37:11 PST ---
(In reply to comment #5)
> Thanks for reporting and patch. Who broke build is me.
> I think we should not add this API in GraphicLayer.
> I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer.
>     virtual void setContentsScale(float) OVERRIDE;
>     virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE;
> How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this.
>     void setContentsScale(float);
>     void setVisibleContentRectTrajectoryVector(const FloatPoint&);
> I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer.
> Could you do that?

Thank you for the tip, of course I will do that. Unfortunately I chose the wrong way of fixing first. Now I see that other platforms do not need these methods.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list