[Webkit-unassigned] [Bug 100995] [Qt][Mac][Win] r133182 broke the build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 16:30:20 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100995





--- Comment #5 from Huang Dongsung <luxtella at company100.net>  2012-11-01 16:31:42 PST ---
Thanks for reporting and patch. Who broke build is me.

I think we should not add this API in GraphicLayer.

I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer.
    virtual void setContentsScale(float) OVERRIDE;
    virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE;

How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this.
    void setContentsScale(float);
    void setVisibleContentRectTrajectoryVector(const FloatPoint&);

I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer.

Could you do that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list