[Webkit-unassigned] [Bug 100674] [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100674





--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-01 03:25:09 PST ---
(From update of attachment 171718)
View in context: https://bugs.webkit.org/attachment.cgi?id=171718&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:549
> -static inline Evas_Object* createEwkView(Evas* canvas, Evas_Smart* smart, PassRefPtr<Ewk_Context> context, WKPageGroupRef pageGroupRef = 0)
> +static inline Evas_Object* createEwkView(Evas* canvas, Evas_Smart* smart, PassRefPtr<Ewk_Context> context, WKPageGroupRef pageGroupRef = 0, bool desktopMode = false)

I hate us calling this desktop mode. The desktop is changing...

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:577
> +    return createEwkView(canvas, createEwkViewSmartClass(), Ewk_Context::create(contextRef), pageGroupRef, true);

an enum would be a lot nicer

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:130
> +    if (!desktopMode)
> +        m_pageViewportController = adoptPtr(new PageViewportController(m_pageProxy.get(), m_pageViewportControllerClient.get()));
>      m_pageProxy->pageGroup()->preferences()->setAcceleratedCompositingEnabled(true);
>      m_pageProxy->pageGroup()->preferences()->setForceCompositingMode(true);
> +    if (m_pageViewportController)
> +        m_pageProxy->setUseFixedLayout(true);

why not do the useFixedLayout further up? do avoid an additional if

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:321
>  void EwkViewImpl::informLoadCommitted()
>  {
> -    m_pageViewportController->didCommitLoad();
> +    if (m_pageViewportController)
> +        m_pageViewportController->didCommitLoad();
> +    else
> +        m_pageViewportControllerClient->didChangeVisibleContents();
>  }

This is weird and confusing. I am not saying it is wrong, but this code just looks really confusing

> Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp:105
> +    if (!m_pageViewportController) {
> +        FloatRect mapRectToWebContent = FloatRect(m_scrollPosition, m_viewportSize);
> +        mapRectToWebContent.scale(1 / m_scaleFactor);
> +        drawingArea()->layerTreeCoordinatorProxy()->setContentsSize(WebCore::FloatSize(size.width(), size.height()));
> +    }

can't you uuse the new toWebContents.mapRect( .. ) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.