[Webkit-unassigned] [Bug 100674] [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100674





--- Comment #8 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-11-01 03:46:09 PST ---
(From update of attachment 171751)
View in context: https://bugs.webkit.org/attachment.cgi?id=171751&action=review

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:96
> +EwkViewImpl::EwkViewImpl(Evas_Object* view, PassRefPtr<Ewk_Context> context, PassRefPtr<WebPageGroup> pageGroup, bool desktopMode)

don't like custom flags, we need to think of it in OOP way and either have another instance of view impl class or encapsulate the behavioural difference in some strategy class.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:130
> +        m_pageProxy->setUseFixedLayout(true);

maybe put it under the same if (!desktopMode) ?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:327
> +    if (m_pageViewportController)

this should be avoided, need some design decision like I said in first comment

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.