[Webkit-unassigned] [Bug 87337] [Blackberry] WebKit's fullscreen mode needs to notify page client.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87337





--- Comment #11 from Chris.Guan <chris.guan at torchmobile.com.cn>  2012-05-30 19:46:42 PST ---
(In reply to comment #10)
> (From update of attachment 144786 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144786&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:5487
> > +        static_cast<Element*>(d->m_fullscreenVideoNode.get())->document()->webkitCancelFullScreen();
> 
> This line is not correct. The m_fullscreenVideoNode is only used by the enterFullScreenForNode path (when fullScreenVideoCapable is true). So it will always be zero here. Was this code path tested?

Max, I reuse m_fullscreenVideoNode in this patch, I assigned/cleared the node in enter/exitFullScreenForElement functions. Chrome should not call "notifyFullScreenVideoExited" when it is not in full screen mode, should it? Yes, anyway, I should have null pointer check or Assert. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.