[Webkit-unassigned] [Bug 87337] [Blackberry] WebKit's fullscreen mode needs to notify page client.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87337


Max Feil <mfeil at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144786|review?                     |review-
               Flag|                            |




--- Comment #10 from Max Feil <mfeil at rim.com>  2012-05-30 12:25:51 PST ---
(From update of attachment 144786)
View in context: https://bugs.webkit.org/attachment.cgi?id=144786&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:5487
> +        static_cast<Element*>(d->m_fullscreenVideoNode.get())->document()->webkitCancelFullScreen();

This line is not correct. The m_fullscreenVideoNode is only used by the enterFullScreenForNode path (when fullScreenVideoCapable is true). So it will always be zero here. Was this code path tested?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.