[Webkit-unassigned] [Bug 87167] [chromium] Cleanup scissor rect computation/use with damage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87167





--- Comment #17 from Dana Jansens <danakj at chromium.org>  2012-05-30 12:35:51 PST ---
(From update of attachment 144892)
View in context: https://bugs.webkit.org/attachment.cgi?id=144892&action=review

Oh I skipped a couple files somehow, oops. A few more small comments.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:317
> +        if (it.representsContributingRenderSurface()) {
> +            if (!it->renderSurface()->scissorRect().isEmpty())

These two lines can be merged.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:324
>          else if (it.representsItself() && !it->visibleLayerRect().isEmpty()) {
>              it->willDraw(m_layerRenderer.get());
> -            pass->appendQuadsForLayer(*it, &occlusionTracker, hadMissingTiles);
> +
> +            if (!it->scissorRect().isEmpty())
> +                pass->appendQuadsForLayer(*it, &occlusionTracker, hadMissingTiles);

Oh, put this scissorRect check in with the visibleLayerRect check. We must call append if we call willDraw.

> Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp:71
> +void CCRenderPass::appendQuadsForRenderSurfaceLayer(CCLayerImpl* layer, CCOcclusionTrackerImpl* occlusionTracker, const FloatRect& rootDamageRect)

rootDamageRect isn't used in here anymore, so we can avoid adding it now?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.