[Webkit-unassigned] [Bug 87167] [chromium] Cleanup scissor rect computation/use with damage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87167





--- Comment #16 from Dana Jansens <danakj at chromium.org>  2012-05-30 12:30:23 PST ---
(From update of attachment 144892)
View in context: https://bugs.webkit.org/attachment.cgi?id=144892&action=review

This is looking really great! A few small nits left from me.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:623
> -    layer->renderSurface()->setScissorRect(this, quad->surfaceDamageRect());
> +    setScissorToRect(quad->scissorRect());
> +

Let's just remove this, as it's already done in drawQuad now :)

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:88
> +static IntRect calculateLayerScissorRect(LayerChromium* layer, const FloatRect& rootDamageRect)
> +{
> +    if (layer->usesLayerClipping())
> +        return layer->clipRect();
> +    return layer->targetRenderSurface()->contentRect();
> +}

Could remove this and template with the above function now?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:101
> +    FloatRect result = CCMathUtil::projectClippedRect(inverseScreenSpaceTransform, rootDamageRect);

nit: s/result/clipAndDamage/ like above? This and calculateLayerScissorRect are more similar than they appear, maybe just reordering stuff inside one of them would make that more obvious. I like that this methods has a clipRect var, then clipAndDamage var. Can we follow this pattern in calculateLayerScissorRect also?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:738
> +static void calculateVisibleLayersAndScissorRects(const LayerList& renderSurfaceLayerList, const FloatRect& rootDamageRect)

nit: calculateVisibleAndScissorRectsInternal?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.