[Webkit-unassigned] [Bug 87696] [FileAPI] Miss FileList test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87696





--- Comment #6 from Li Yin <li.yin at intel.com>  2012-05-29 01:52:52 PST ---
(In reply to comment #3)
> (From update of attachment 144455 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144455&action=review
> 
> The change looks OK.
> 
> > LayoutTests/fast/files/file-list-test.html:17
> > +    debug("files.item(0): " + files.item(0));
> 
> Nit: Maybe we want to pass more than two files for testing?

Add two files in the List

> 
> > LayoutTests/fast/files/file-list-test.html:32
> > +function runTests()
> > +{
> > +    eventSender.beginDragWithFiles(['resources/UTF8.txt']);
> > +    eventSender.mouseMoveTo(10, 10);
> > +    eventSender.mouseUp();
> > +}
> > +
> > +if (window.eventSender) {
> > +    layoutTestController.dumpAsText();
> > +    window.onload = runTests;
> > +}
> 
> I guess you can simplify the code.
> 
> - You do not need to call layoutTestController.dumpAsText().
> - You can write the <script> after </body>, by which you can avoid hooking window.onload.

Simply the code, done.

Thanks for your review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.