[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048





--- Comment #29 from Takashi Sakamoto <tasak at google.com>  2012-05-25 03:32:37 PST ---
(In reply to comment #28)
> (From update of attachment 142694 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142694&action=review
> 
> Basically looks good! I added a few comments.
> 
> > Source/WebCore/css/StyleResolver.cpp:1170
> > +      m_resetStyleInheritance = false;
> 
> It looks we don't need to add m_resetStyleInheritance.
> Setting NULL to m_parentStyle will work fine for that purpose.
> 
> > Source/WebCore/css/StyleResolver.cpp:1680
> > +    if (m_resetStyleInheritance) {
> 
> Why do we need this? Is it different from the default?

I need this because defaultStyle doesn't have any font information. 

Font information is stored in "inherited" member variable in RenderStyle. The defaultStyle's "inherited" is initialized by using StyleInheritedData::StyleInheritedData(). The constructor initializes "font" member variable by using default  constructor. This causes a problem, the size of textNode in style-inheritance reseted node is 0x0.

Best regards,
Takashi Sakamoto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.