[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048





--- Comment #28 from Hajime Morrita <morrita at google.com>  2012-05-20 17:48:44 PST ---
(From update of attachment 142694)
View in context: https://bugs.webkit.org/attachment.cgi?id=142694&action=review

Basically looks good! I added a few comments.

> Source/WebCore/css/StyleResolver.cpp:1170
> +      m_resetStyleInheritance = false;

It looks we don't need to add m_resetStyleInheritance.
Setting NULL to m_parentStyle will work fine for that purpose.

> Source/WebCore/css/StyleResolver.cpp:1680
> +    if (m_resetStyleInheritance) {

Why do we need this? Is it different from the default?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.