[Webkit-unassigned] [Bug 87044] [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87044





--- Comment #3 from Hugo Parente Lima <hugo.lima at openbossa.org>  2012-05-21 14:17:59 PST ---
(In reply to comment #2)
> (From update of attachment 143093 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143093&action=review
> 
> The #ifdef cleanup needs to go in a separate patch. He has nothing to do with the main content of the patch (especially that it is in a different file).
> 
> > Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:242
> > +    QEvent* pressEvent = new QKeyEvent(QEvent::KeyPress, code, modifiers, keyText);
> 
> nitpick: Why modifying QKeyEvent to QEvent? Keep it specialized.

Because it don't need to be specialized besides it's used only in the next line =], but ok, I can change that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.