[Webkit-unassigned] [Bug 87044] [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87044


Alexis Menard (darktears) <alexis.menard at openbossa.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143093|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Alexis Menard (darktears) <alexis.menard at openbossa.org>  2012-05-21 14:15:18 PST ---
(From update of attachment 143093)
View in context: https://bugs.webkit.org/attachment.cgi?id=143093&action=review

The #ifdef cleanup needs to go in a separate patch. He has nothing to do with the main content of the patch (especially that it is in a different file).

> Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:242
> +    QEvent* pressEvent = new QKeyEvent(QEvent::KeyPress, code, modifiers, keyText);

nitpick: Why modifying QKeyEvent to QEvent? Keep it specialized.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.