[Webkit-unassigned] [Bug 86195] [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86195





--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-16 18:05:43 PST ---
(From update of attachment 142311)
View in context: https://bugs.webkit.org/attachment.cgi?id=142311&action=review

>> Source/WebKit/efl/ewk/ewk_security_origin.cpp:105
>> +    return ewk_security_origin_new(WebCore::SecurityOrigin::createFromString(String (url)).get());
> 
> extra space here QString(url). Also you should probably use QString::fromUTF8(url) instead.

QString is for QT port. We just enough to use String::fromUTF8().

> Source/WebKit/efl/ewk/ewk_security_origin.h:99
> +EAPI uint64_t             ewk_security_origin_web_database_quota_get(const Ewk_Security_Origin *o);

As far as I know, webkit reviewer don't like to mix patch. You don't mention to fix indentation. I would recommend to file new bug to fix indentation. I think indentation patch is able to be landed without review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.