[Webkit-unassigned] [Bug 86557] Allow WebTextFieldDecoratorClient to see applied decorations.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86557





--- Comment #7 from Garrett Casto <gcasto at chromium.org>  2012-05-16 11:37:12 PST ---
(In reply to comment #6)
> (From update of attachment 142294 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142294&action=review
> 
> > Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:143
> > +    if (inlineStyle()->getPropertyValue(CSSPropertyVisibility) == "hidden"
> > +        || inputStyle->visibility() == HIDDEN)
> > +        style->setVisibility(HIDDEN);
> 
> If you need this code, something has gone horribly wrong.
> 

So I don't understand the distinction between styles set by SetInlineStyleProperty and those set via RenderStyle, but just setting the inline style (either visibility:hidden or display:none) will not cause the element to disappear. As far as I can tell it has to be set here, and propagating from the inline style just seemed like the easiest way to accomplish this. Like I said, I don't understand why because I don't understand the distinction between them, but it's how it works at the moment.

The second line is because currently if the HTMLInputElement is hidden, the decorator still shows up. This doesn't seem like it should happen either.

> > Source/WebKit/chromium/public/WebStyledElement.h:32
> > +#define WebStyledElement_h
> 
> As I mentioned before, it's not the right approach. Exposing StyledElement in WebKit API is an overkill for this solution.
> 
> Perhaps instead we could morph the API to be a list of decorators in a document?
> 
> Then, we can listen to normal document events and react to them by iterating through the decorators and operating on them. In other words, instead of exposing WebStyledElement, expose the WebTextFieldDecorator? WDYT?

I'm not sure I understand what you are suggesting. Exposing WebTextFieldDecorator instead of WebStyledElement seems fine to me, though we can do that by just changing the function definition of decorationAdded(). It seems like you are suggesting something larger. How exactly are you proposing to change WebTextFieldDecoratorClient?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.