[Webkit-unassigned] [Bug 86557] Allow WebTextFieldDecoratorClient to see applied decorations.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86557


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142294|review?                     |review-
               Flag|                            |




--- Comment #6 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-05-16 11:16:33 PST ---
(From update of attachment 142294)
View in context: https://bugs.webkit.org/attachment.cgi?id=142294&action=review

> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:143
> +    if (inlineStyle()->getPropertyValue(CSSPropertyVisibility) == "hidden"
> +        || inputStyle->visibility() == HIDDEN)
> +        style->setVisibility(HIDDEN);

If you need this code, something has gone horribly wrong.

> Source/WebKit/chromium/public/WebStyledElement.h:32
> +#define WebStyledElement_h

As I mentioned before, it's not the right approach. Exposing StyledElement in WebKit API is an overkill for this solution.

Perhaps instead we could morph the API to be a list of decorators in a document?

Then, we can listen to normal document events and react to them by iterating through the decorators and operating on them. In other words, instead of exposing WebStyledElement, expose the WebTextFieldDecorator? WDYT?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.