[Webkit-unassigned] [Bug 86591] [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 01:28:51 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86591


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142188|                            |review?
               Flag|                            |




--- Comment #1 from Hironori Bono <hbono at chromium.org>  2012-05-16 01:27:55 PST ---
Created an attachment (id=142188)
 --> (https://bugs.webkit.org/attachment.cgi?id=142188&action=review)
The proposed solution 1

Greetings,

I have written a change that adds a virtual function TextCheckerClient::shouldEraseMarkersAfterChangeSelection to remove these #if,..,#endif blocks. I would like to set r? to try this change on EWS bots to check if they can compile this change. (I have verified I can compile this change on Chromium, Mac, Win, and Qt, though.)

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list