[Webkit-unassigned] [Bug 86356] [GTK] Add API to get plugins to WebKit2 GTK+
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 23:56:25 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=86356
--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> 2012-05-15 23:55:29 PST ---
(In reply to comment #3)
> (From update of attachment 141692 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141692&action=review
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:273
> > +static void webkitWebContextGetPluginThread(GSimpleAsyncResult* result, GObject* object, GCancellable*)
>
> Nit: extra space before GCancellable.
oh, ok
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:299
> > + g_simple_async_result_run_in_thread(result.get(), webkitWebContextGetPluginThread, G_PRIORITY_DEFAULT, cancellable);
>
> Do you mind explaining why you call pluginInfoStore().plugins() in a thread? Why not simply make this method synchronous and call pluginInfoStore().plugins() right here?
Because it's blocking and slow.
> I worry because I'm not sure that the WebContext is thread-safe.
pluginInfoStore().plugins() is thread-safe.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list