[Webkit-unassigned] [Bug 86356] [GTK] Add API to get plugins to WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86356





--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2012-05-15 11:51:44 PST ---
(From update of attachment 141692)
View in context: https://bugs.webkit.org/attachment.cgi?id=141692&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:273
> +static void webkitWebContextGetPluginThread(GSimpleAsyncResult* result, GObject* object,  GCancellable*)

Nit: extra space before GCancellable.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:299
> +    g_simple_async_result_run_in_thread(result.get(), webkitWebContextGetPluginThread, G_PRIORITY_DEFAULT, cancellable);

Do you mind explaining why you call pluginInfoStore().plugins() in a thread? Why not simply make this method synchronous and call pluginInfoStore().plugins() right here?

I worry because I'm not sure that the WebContext is thread-safe.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.