[Webkit-unassigned] [Bug 86129] [BlackBerry] Enable the Fullscreen API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86129





--- Comment #11 from Max Feil <mfeil at rim.com>  2012-05-11 11:33:46 PST ---
(In reply to comment #10)

> You could combine:
> if (HTMLMediaElement* element = static_cast<HTMLMediaElement*>(m_webCorePlayer->mediaPlayerClient()))
>   element->exitFullscreen();

I took your suggestion and made this minor change for my next patch.

> > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:129
> >      }
> 
> Is it possible to have a test for this or is an existing test covering it?

This is just a null pointer check to avoid a seg fault upon Browser shutdown. I don't think most null pointer checks need a Layout test.

> > Source/WebKit/blackberry/Api/WebPage.cpp:6017
> > +    coreSettings->setFullScreenEnabled(true);
> 
> Do we want to turn it off at any time? Is it setting dependent?

It is not setting dependent. I can't think of a reason to ever disable fullscreen elements in a document. The web page can disallow fullscreen per frame/iframe, as per the Fullscreen API spec.

> Lacks period at end.

I fixed the missing periods at the end of my single sentence comments. Will be in my next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.