[Webkit-unassigned] [Bug 86129] [BlackBerry] Enable the Fullscreen API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86129


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141265|review?                     |review-
               Flag|                            |




--- Comment #10 from Rob Buis <rwlbuis at gmail.com>  2012-05-11 07:34:04 PST ---
(From update of attachment 141265)
View in context: https://bugs.webkit.org/attachment.cgi?id=141265&action=review

Looks good, can be improved some more.

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:128
> +            element->exitFullscreen();

You could combine:
if (HTMLMediaElement* element = static_cast<HTMLMediaElement*>(m_webCorePlayer->mediaPlayerClient()))
  element->exitFullscreen();

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:129
>      }

Is it possible to have a test for this or is an existing test covering it?

> Source/WebKit/blackberry/Api/WebPage.cpp:6017
> +    coreSettings->setFullScreenEnabled(true);

Do we want to turn it off at any time? Is it setting dependent?

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:740
> +        // This is where we would hide the browser's chrome if we wanted to

Lacks period at end.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:749
> +        // The Browser chrome has its own fullscreen video widget

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:753
> +        // if hidden above

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.