[Webkit-unassigned] [Bug 85624] Web Inspector: HTMLCanvasElement::didDraw instrumentation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85624





--- Comment #8 from eustas.bug at gmail.com  2012-05-10 01:22:04 PST ---
(From update of attachment 140392)
View in context: https://bugs.webkit.org/attachment.cgi?id=140392&action=review

>> Source/WebCore/html/HTMLCanvasElement.cpp:232
>> +        InspectorInstrumentation::didInvalidateCanvasRect(this->document(), dirtyRect);
> 
> simply document()

Done.

>> Source/WebCore/inspector/TimelineRecordFactory.cpp:196
>> +PassRefPtr<InspectorObject> TimelineRecordFactory::createInvalidateCanvasRectData(const IntRect& rect)
> 
> This is just a rect data, you should re-use createPaintData.

Did you mean: convert to IntRect to FloatRect and pass it to createPaintData?

>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:519
>> +                contentHelper._appendTextRow(WebInspector.UIString("Location"), WebInspector.UIString("(%d, %d)", this.data["x"], this.data["y"]));
> 
> Please add corresponding localizedStrings.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.