[Webkit-unassigned] [Bug 85624] Web Inspector: HTMLCanvasElement::didDraw instrumentation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 5 08:23:44 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=85624


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140392|review?                     |review-
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2012-05-05 08:23:43 PST ---
(From update of attachment 140392)
View in context: https://bugs.webkit.org/attachment.cgi?id=140392&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:232
> +        InspectorInstrumentation::didInvalidateCanvasRect(this->document(), dirtyRect);

simply document()

> Source/WebCore/inspector/TimelineRecordFactory.cpp:196
> +PassRefPtr<InspectorObject> TimelineRecordFactory::createInvalidateCanvasRectData(const IntRect& rect)

This is just a rect data, you should re-use createPaintData.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:519
> +                contentHelper._appendTextRow(WebInspector.UIString("Location"), WebInspector.UIString("(%d, %d)", this.data["x"], this.data["y"]));

Please add corresponding localizedStrings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list