[Webkit-unassigned] [Bug 85577] [BlackBerry] Autofill feature implementation for BlackBerry porting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85577





--- Comment #3 from Jonathan Dong <jonathan.dong at torchmobile.com.cn>  2012-05-09 18:34:12 PST ---
(From update of attachment 140923)
View in context: https://bugs.webkit.org/attachment.cgi?id=140923&action=review

>> Source/WebKit/blackberry/Api/WebPage.cpp:2136
>> +        textItems.push_back(candidates[i].utf8().data());
> 
> It would be great if we would not have to do the WTF::Vector to vector conversion but I guess that might be hard...

Thanks Rob, well this vector is generated from autofill database querying, those codes are in WebCore/platform/network/blackberry, which suppose we should not use std::vector there. That means we need to convert the WTF::Vector to std::vector somewhere before we send them out of webkit.
Fortunately the overhead is not heavy by my test for now. To solve this issue I think we can move AutofillBackingStore.[cpp|h] into WebKit/blackberry/WebCoreSupport and replace the WTF::Vector with std::vector in the future patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.