[Webkit-unassigned] [Bug 85577] [BlackBerry] Autofill feature implementation for BlackBerry porting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85577


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140923|review?                     |review+
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-05-09 09:06:32 PST ---
(From update of attachment 140923)
View in context: https://bugs.webkit.org/attachment.cgi?id=140923&action=review

Looks good, please fix the issues before landing.

> Source/WebKit/blackberry/Api/WebPage.cpp:2136
> +        textItems.push_back(candidates[i].utf8().data());

It would be great if we would not have to do the WTF::Vector to vector conversion but I guess that might be hard...

> Source/WebKit/blackberry/Api/WebPage_p.h:193
> +    void notifyPopupAutofillDialog(const WTF::Vector<WTF::String>&, const WebCore::IntRect&);

I don't think you need the WTF:: prefixes here.

> Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h:114
> +

No need for this empty line.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:724
> +credentialManager().saveCredentialIfConfirmed(m_webPagePrivate, CredentialTransformData(prpFormState->form()));

Indent properly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.