[Webkit-unassigned] [Bug 84414] Expose a flag so that fullscreen video on android can work with FULLSCREEN_API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84414





--- Comment #29 from Benjamin Poulain <benjamin at webkit.org>  2012-05-09 15:15:25 PST ---
> > You have not explained why this is valid regarding const-correctness.
> 
> Because when we call this, it won't change the object. If the const-correctness really affects the const-correctness in your implementation, we can remove that const away.  

In WebKit, we consider the semantic const correctness. not the C++ type checking.

Yes, I think the "const" should not be there.


> > > Since this return value is not used when ENABLE(PLUGIN_PROXY_FOR_VIDEO) is set, returning true should just be fine.
> > 
> > This sounds like reasons to have a "canEnterFullScreen()" method or something similar. Now you changed the API so that enterFullScreen() can fail. The fact that the existing code ignore this is no excuse.
> 
> So in the NATIVE_FULLSCREEN_VIDEO case, there is nothing in the DOM that blocks the media element from going fullscreen. Only the native mediaplayer knows whether it can enter fullscreen or not. And also because that the MediaPlayerPrivate can get deleted when this is called, so enterFullscreen() is not guaranteed to be successful.

If you chance the contract of an API, you have to do it all the way.

Please explain how can the MediaPlayerPrivate get deleted in MediaPlayer::enterFullScreen() because that is relevant to the other use of this API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.