[Webkit-unassigned] [Bug 84414] Expose a flag so that fullscreen video on android can work with FULLSCREEN_API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84414





--- Comment #28 from Min Qin <qinmin at chromium.org>  2012-05-09 13:54:19 PST ---
(In reply to comment #27)
> > > Why would you change this to be const?? That is not a method free of side effects on the state of the media player.
> 
> You have not explained why this is valid regarding const-correctness.

Because when we call this, it won't change the object. If the const-correctness really affects the const-correctness in your implementation, we can remove that const away.  
> 
> > So this is what could happen for chrome on android, when calling enterFullscreen() it could actually fail for the following 2 reasons:
> > 1. if the MediaPlayerPrivate object is gone.
> > 2. the native media player is already in fullscreen mode.
> > 
> > Since this return value is not used when ENABLE(PLUGIN_PROXY_FOR_VIDEO) is set, returning true should just be fine.
> 
> This sounds like reasons to have a "canEnterFullScreen()" method or something similar. Now you changed the API so that enterFullScreen() can fail. The fact that the existing code ignore this is no excuse.

(In reply to comment #27)
> > > Why would you change this to be const?? That is not a method free of side effects on the state of the media player.
> 
> You have not explained why this is valid regarding const-correctness.
> 
> > So this is what could happen for chrome on android, when calling enterFullscreen() it could actually fail for the following 2 reasons:
> > 1. if the MediaPlayerPrivate object is gone.
> > 2. the native media player is already in fullscreen mode.
> > 
> > Since this return value is not used when ENABLE(PLUGIN_PROXY_FOR_VIDEO) is set, returning true should just be fine.
> 
> This sounds like reasons to have a "canEnterFullScreen()" method or something similar. Now you changed the API so that enterFullScreen() can fail. The fact that the existing code ignore this is no excuse.

So in the NATIVE_FULLSCREEN_VIDEO case, there is nothing in the DOM that blocks the media element from going fullscreen. Only the native mediaplayer knows whether it can enter fullscreen or not. And also because that the MediaPlayerPrivate can get deleted when this is called, so enterFullscreen() is not guaranteed to be successful.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.