[Webkit-unassigned] [Bug 85575] [BlackBerry] Autofill backing store implementation upstream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85575





--- Comment #6 from Jonathan Dong <jonathan.dong at torchmobile.com.cn>  2012-05-04 09:53:41 PST ---
(From update of attachment 140251)
View in context: https://bugs.webkit.org/attachment.cgi?id=140251&action=review

>> Source/WebCore/platform/network/blackberry/AutofillBackingStore.cpp:56
>> +        m_database.close();
> 
> Should the dtor here do similar things like close()? Can you assure somewhow close() is called before the dtor is called? Is the dtor called at all?

well that's a good question. I think as AutofillBackingStore works as a singleton, close() should make as a private function and called from dtor, we shouldn't let people call close() explicitly.
dtor should be called after exit main(), I'll make a build and debug it tomorrow to see if it works as expected, too tired today.
I guess CredentialBackingStore has the same issue, sorry for that. Will fix it together with next patch. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.