[Webkit-unassigned] [Bug 75825] webkit-patch land should automatically add svn:mime-type for .png files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75825





--- Comment #14 from Balazs Ankes <bank at inf.u-szeged.hu>  2012-05-04 05:51:11 PST ---
(In reply to comment #13)
> (From update of attachment 140028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140028&action=review
> 
> This looks pretty good (with the one quibble), but normally we require unit tests for new code. Can you add some unit tests as well?

Yes, I can. I asked it earlier but I didn't get answer.
> 
> > Tools/Scripts/webkitpy/common/checksvnconfigfile.py:46
> > +        return (1, 1, 1)
> 
> You should use True/False instead of 1/0.

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.