[Webkit-unassigned] [Bug 75825] webkit-patch land should automatically add svn:mime-type for .png files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 3 16:48:44 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=75825
Dirk Pranke <dpranke at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #140028|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #13 from Dirk Pranke <dpranke at chromium.org> 2012-05-03 16:48:43 PST ---
(From update of attachment 140028)
View in context: https://bugs.webkit.org/attachment.cgi?id=140028&action=review
This looks pretty good (with the one quibble), but normally we require unit tests for new code. Can you add some unit tests as well?
> Tools/Scripts/webkitpy/common/checksvnconfigfile.py:46
> + return (1, 1, 1)
You should use True/False instead of 1/0.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list