[Webkit-unassigned] [Bug 27577] [CSS3 Backgrounds and Borders] Add background-size to the background shorthand

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27577


Joe Thomas <joethomas at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |joethomas at motorola.com
                   |kit.org                     |
 Attachment #140100|                            |review?
               Flag|                            |




--- Comment #17 from Joe Thomas <joethomas at motorola.com>  2012-05-03 14:54:03 PST ---
Created an attachment (id=140100)
 --> (https://bugs.webkit.org/attachment.cgi?id=140100&action=review)
Patch-updated

Added the background-size property to StylePropertySet::getPropertyValue & StylePropertyShorthand::backgroundShorthand()

But I haven't added background-size to background shorthand property in CSSComputedStyleDeclaration. Tried to add / seperator between background-position and background-size in CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties with 

 if (shorthand.properties()[i] == CSSPropertyBackgroundSize)
    list->append(cssValuePool().createValue("/", CSSPrimitiveValue::CSS_STRING));

This adds the seperator into the shorthand with single quotes, like 

rgb(255, 0, 0) url(dummy://test.png) repeat scroll 50px 50px '/' 50% 25%

The single quote is getting added to the separator in CSSPrimitiveValue::customCssText() with "quoteCSSStringIfNeeded(m_value.string)". 

Can someone please suggest a way to avoid this? Is it a good idea to create a PlainTextCSSValue class derived from CSSValue and return the string alone without any modification?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.