[Webkit-unassigned] [Bug 27577] [CSS3 Backgrounds and Borders] Add background-size to the background shorthand

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27577





--- Comment #16 from Alexis Menard (darktears) <alexis.menard at openbossa.org>  2012-05-02 05:14:01 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > (From update of attachment 139681 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=139681&action=review
> > 
> Thanks for the review.
> 
> > In the same way you also should patch StylePropertySet::getPropertyValue, StylePropertyShorthand::backgroundShorthand() and CSSComputedStyleDeclaration 
> and it would be nice to add a test case to cover these cases. 
> 
> I will cover these cases.
> 
> You also want to test other values than initial (well maybe you did but it seemed there was a problem when you uploaded)
> > 
> Can you please let me know what is the problem that you are seeing? It looks fine to me.
> 
> > > LayoutTests/fast/backgrounds/size/backgroundSize-in-background-shorthand-expected.html:16
> > > +</html>
> > 
> > It doesn't seem to be the right file.
> 
> This is a new reftest added by me. Do you mean to say that the path is wrong?

Maybe you don't need a reftest. I simple JS based test like in fast/css/getComputedStyle/ is good enough. I feel this :

shouldBe("computedStyle.getPropertyValue('border-width')", "'10px 5px 4px 3px'");

is more easy to read and is more what you want to test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.