[Webkit-unassigned] [Bug 85063] Add low memory check in ExecutableAllocator::underMemoryPressure()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85063


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139452|review?                     |review-
               Flag|                            |




--- Comment #24 from Filip Pizlo <fpizlo at apple.com>  2012-05-03 13:50:44 PST ---
(From update of attachment 139452)
View in context: https://bugs.webkit.org/attachment.cgi?id=139452&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        Call WTF::isSystemMemoryLow() to check whether system memory is low in
> +        ExecutableAllocator::underMemoryPressure(). This will force collecting
> +        of garbage, thus avoiding out of system memory while at the same time
> +        we have a lot of unused memory waiting to be released.

I'm not sure I buy this.  ExecutableAllocator has _nothing_ to do with garbage collection.  It only deals with JIT memory.  This method returning true should only cause us to jettison JIT memory; it will not cause any other kinds of memory reclamation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.