[Webkit-unassigned] [Bug 85063] Add low memory check in ExecutableAllocator::underMemoryPressure()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85063





--- Comment #23 from Benjamin Poulain <benjamin at webkit.org>  2012-05-03 13:44:57 PST ---
> As for us the problem is when the browser is too busy, the garbage collection might not get a chance to execute. And it seems to us checking low memory in ExecutableAllocator::underMemoryPressure() is a nice place to do that check and force a garbage collection.

For this sounds like this could simply be cutting corners for one particular case.

For me, ExecutableAllocator::underMemoryPressure()  is not the obvious response to low memory conditions. Dropping giant layers and images should be a first step.

This is why I think the memory pressure should be consistent across the whole WebKit and not implemented differently in each component.

> There is a layer conflict JSC cannot call WebCore. WebCore can implement a handler for memory pressure, but I think checking memory status should be done in lower layer.

JSC does call WebCore all the time, that is called the binding ;)

More seriously, the solution could be to move all memory management to WTF. Or it could be that JSC has a callback to know the memory conditions. I don't know what it the best solution, but I think adding something transversal to WebCore might not be the best solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.