[Webkit-unassigned] [Bug 85118] REGRESSION(r95249): Iframes are printed blank

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85118





--- Comment #21 from Eric Seidel <eric at webkit.org>  2012-05-02 11:10:47 PST ---
(From update of attachment 139594)
View in context: https://bugs.webkit.org/attachment.cgi?id=139594&action=review

I like the idea.  I'm not 100% sure the patch is complete yet though.

> Source/WebCore/rendering/RenderView.cpp:116
> -    if (printing())
> +    if (usePrintingLayout())

IIRC, these are not the only uses of printing() in this file.  Maybe I'm thinking of FrameView.  It seems odd that the inner FrameView's would need any special handling either.

> Source/WebCore/rendering/RenderView.cpp:664
> +    if (m_frameView) {
> +        if (Frame* frame = m_frameView->frame()) {
> +            if (FrameTree* tree = frame->tree()) {
> +                // Only root frame should have special handling for printing.
> +                if (tree->parent())
> +                    return false;
> +            }
> +        }
> +    }

I think there is a way to check frame->tree()->top()?  Maybe there is an isTop?  I'm surprised you have to write your own ancestor walk here.

> Source/WebCore/rendering/RenderView.h:89
>      bool printing() const;
> +    bool usePrintingLayout() const;

I'm confused why either of these would be public.  Do we need to audit other callers?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.