[Webkit-unassigned] [Bug 85118] REGRESSION(r95249): Iframes are printed blank

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85118





--- Comment #20 from Alexey Proskuryakov <ap at webkit.org>  2012-05-02 11:06:41 PST ---
(From update of attachment 139594)
View in context: https://bugs.webkit.org/attachment.cgi?id=139594&action=review

You should set r? flag, so that an expert in rendering/printing would eventually take a look.

> Source/WebCore/ChangeLog:13
> +        Disables special processing for printing for subframes in RenderView. Only root
> +        frame requires special handling because it deppends on page size.

Frames in a frameset also depend on page size AFAICT.

> Source/WebCore/rendering/RenderView.cpp:665
> +    if (m_frameView) {
> +        if (Frame* frame = m_frameView->frame()) {
> +            if (FrameTree* tree = frame->tree()) {
> +                // Only root frame should have special handling for printing.
> +                if (tree->parent())
> +                    return false;
> +            }
> +        }
> +    }
> +    return true;

So if any of these is null, this function will return true? That seems strange.

As far as coding style goes, WebKit uses early returns, not deep nesting for conditions like this.

I think that the comment about root frame should explain why.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.