[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75553


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134767|review?                     |review+
               Flag|                            |




--- Comment #46 from Martin Robinson <mrobinson at webkit.org>  2012-03-30 11:48:17 PST ---
(From update of attachment 134767)
View in context: https://bugs.webkit.org/attachment.cgi?id=134767&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:81
>> +    bool fullScreenEnabled;
> 
> It seems this is only used inside #if ENABLE(FULLSCREEN_API) #endif blocks, so maybe we should add #if here?

For the naming of this perhaps "inFullScreenMode", "fullScreenModeActive", or "fullScreenActive" would make it clearer.

As an asides, it's a bit odd that in WebKit2 it's referred to as "FullScreen" (i.e. "full screen"), but the guard is "FULLSCREEN" (i.e. "fullscreen").

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:293
> +        switch (event->keyval) {
> +        case GDK_KEY_Escape:
> +        case GDK_KEY_f:
> +        case GDK_KEY_F:
> +            webkitWebViewBaseExitFullScreen(webViewBase);

I guess this will be an issue if a game wants to go fullscreen and use the 'f' key?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.